Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added flg that can disable to ingress defaultBackend #1976

Conversation

takuyaymd
Copy link
Contributor

@takuyaymd takuyaymd commented Mar 13, 2023

SSIA (vald-lb-gateway, vald-filter-gateway)

Description:

When running Vald with multiple Namespaces in the same Kubernetes cluster, I had to disable defaultBackend depending on the infrastructure situation, So I added a flag to disable defaultBackend.

Related Issue:

Versions:

  • Go Version: 1.20.2
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 2.0.9

Checklist:

Special notes for your reviewer:

@vankichi vankichi requested review from vankichi and hlts2 May 24, 2023 02:45
charts/vald/values.yaml Outdated Show resolved Hide resolved
charts/vald/values.yaml Outdated Show resolved Hide resolved
@CLAassistant
Copy link

CLAassistant commented May 25, 2023

CLA assistant check
All committers have signed the CLA.

@takuyaymd takuyaymd force-pushed the takuyaymd-feature/gateway-lb/add-default-backend-flag branch 2 times, most recently from 57da0e8 to 8caa994 Compare May 25, 2023 01:53
@takuyaymd takuyaymd changed the title Added flg that can disable to ingress defaultBackend [WIP]Added flg that can disable to ingress defaultBackend May 26, 2023
@takuyaymd takuyaymd changed the title [WIP]Added flg that can disable to ingress defaultBackend Support for advanced settings and disabling of DefaultBackend May 29, 2023
@takuyaymd takuyaymd changed the title Support for advanced settings and disabling of DefaultBackend Added flg that can disable to ingress defaultBackend May 30, 2023
charts/vald/templates/gateway/filter/ing.yaml Outdated Show resolved Hide resolved
charts/vald/templates/gateway/lb/ing.yaml Outdated Show resolved Hide resolved
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants