-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added flg that can disable to ingress defaultBackend #1976
Merged
kpango
merged 20 commits into
vdaas:main
from
takuyaymd:takuyaymd-feature/gateway-lb/add-default-backend-flag
May 30, 2023
Merged
Added flg that can disable to ingress defaultBackend #1976
kpango
merged 20 commits into
vdaas:main
from
takuyaymd:takuyaymd-feature/gateway-lb/add-default-backend-flag
May 30, 2023
+60
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eature/gateway-lb/add-default-backend-flag
vankichi
reviewed
May 24, 2023
hlts2
reviewed
May 24, 2023
takuyaymd
force-pushed
the
takuyaymd-feature/gateway-lb/add-default-backend-flag
branch
2 times, most recently
from
May 25, 2023 01:53
57da0e8
to
8caa994
Compare
…eature/gateway-lb/add-default-backend-flag
https://github.com/takuyaymd/vald into takuyaymd-feature/gateway-lb/add-default-backend-flag
…eature/gateway-lb/add-default-backend-flag
takuyaymd
changed the title
Added flg that can disable to ingress defaultBackend
[WIP]Added flg that can disable to ingress defaultBackend
May 26, 2023
takuyaymd
changed the title
[WIP]Added flg that can disable to ingress defaultBackend
Support for advanced settings and disabling of DefaultBackend
May 29, 2023
takuyaymd
changed the title
Support for advanced settings and disabling of DefaultBackend
Added flg that can disable to ingress defaultBackend
May 30, 2023
vankichi
requested changes
May 30, 2023
kpango
approved these changes
May 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
vankichi
approved these changes
May 30, 2023
This was referenced Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSIA (vald-lb-gateway, vald-filter-gateway)
Description:
When running Vald with multiple Namespaces in the same Kubernetes cluster, I had to disable defaultBackend depending on the infrastructure situation, So I added a flag to disable defaultBackend.
Related Issue:
Versions:
Checklist:
Special notes for your reviewer: